Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2024-07-03] Manual Dependency Bump #18266

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[2024-07-03] Manual Dependency Bump #18266

merged 2 commits into from
Jul 3, 2024

Conversation

ArkaSaha30
Copy link
Contributor

@k8s-ci-robot
Copy link

Hi @ArkaSaha30. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jul 2, 2024

/ok-to-test

@henrybear327
Copy link
Contributor

@ArkaSaha30 the commit message format according to the guide is of the format "dependency: bump github.com/spf13/cobra from 1.6.1 to 1.7.0" :)

ArkaSaha30 added 2 commits July 3, 2024 00:56
@ArkaSaha30
dependency: bump github.com/bgentry/speakeasy from 0.1.0 to 0.2.0
708c3d8 
This commit will bump dependency github.com/bgentry/speakeasy from 0.1.0 to 0.2.0
raised by dependabot.

Signed-off-by: ArkaSaha30 <[email protected]>
@ArkaSaha30
dependency: bump github.com/prometheus/common from 0.54.0 to 0.55.0
fc33323 
This commit will bump the dependency github.com/prometheus/common from 0.54.0 to 0.55.0

Signed-off-by: ArkaSaha30 <[email protected]>
ivanvc
ivanvc approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ArkaSaha30.

ahrtr
ahrtr approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@ahrtr ahrtr merged commit 0f24953 into etcd-io:main Jul 3, 2024
47 checks passed
@ivanvc
Copy link
Member

ivanvc commented Jul 3, 2024 •
edited
Loading

@ArkaSaha30, oh I just noticed that I think you missed github.com/prometheus/common from /tools/mod (#18261).

I'm checking why make verify-dep didn't fail, and it's because it doesn't check the dependencies inside /tools/mod 😱

@ivanvc ivanvc mentioned this pull request Jul 3, 2024
Closed
@ahrtr
Copy link
Member

ahrtr commented Jul 3, 2024

@ArkaSaha30, oh I just noticed that I think you missed github.com/prometheus/common from /tools/mod (#18261).

I'm checking why make verify-dep didn't fail, and it's because it doesn't check the dependencies inside /tools/mod 😱

Thanks @ivanvc. Let's just deliver a separate PR to fix it.

@ArkaSaha30 ArkaSaha30 mentioned this pull request Jul 3, 2024
Merged
@henrybear327
Copy link
Contributor

@ArkaSaha30 please update https://docs.google.com/spreadsheets/d/1jodHIO7Dk2VWTs1IRnfMFaRktS9IH8XRyifOnPdSY8I/edit?gid=1394774387#gid=1394774387 with the link to this PR (and the follow-up PR)! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees
No one assigned
Labels
area/clientv3 area/etcdctl area/etcdutl area/testing ok-to-test size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArkaSaha30 @k8s-ci-robot @ahrtr @henrybear327 @ivanvc